Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Search Aggregation codes #3451

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Jun 1, 2023

No description provided.

@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. experimental labels Jun 1, 2023
@sazzad16 sazzad16 added this to the 5.0.0 milestone Jun 1, 2023
@sazzad16 sazzad16 force-pushed the rs-aggr-refactor branch from 39d5d80 to 632f9c0 Compare June 1, 2023 11:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage: 72.50% and project coverage change: +0.14 🎉

Comparison is base (0f760bc) 71.16% compared to head (70169ca) 71.31%.

❗ Current head 70169ca differs from pull request most recent head 1bdf7ea. Consider uploading reports for the commit 1bdf7ea to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3451      +/-   ##
============================================
+ Coverage     71.16%   71.31%   +0.14%     
+ Complexity     4742     4737       -5     
============================================
  Files           275      274       -1     
  Lines         14748    14696      -52     
  Branches        998      992       -6     
============================================
- Hits          10495    10480      -15     
+ Misses         3816     3785      -31     
+ Partials        437      431       -6     
Impacted Files Coverage Δ
...ava/redis/clients/jedis/search/FTSearchParams.java 67.48% <ø> (ø)
...rc/main/java/redis/clients/jedis/search/Query.java 78.50% <ø> (ø)
...java/redis/clients/jedis/search/aggr/Reducers.java 20.00% <18.18%> (+7.50%) ⬆️
.../java/redis/clients/jedis/search/aggr/Reducer.java 68.18% <62.50%> (+8.18%) ⬆️
.../clients/jedis/search/aggr/AggregationBuilder.java 84.70% <84.09%> (-2.05%) ⬇️
...ain/java/redis/clients/jedis/search/FieldName.java 74.28% <100.00%> (+9.16%) ⬆️
...ava/redis/clients/jedis/search/SearchProtocol.java 97.77% <100.00%> (ø)
...in/java/redis/clients/jedis/search/aggr/Group.java 100.00% <100.00%> (+23.07%) ⬆️
...ain/java/redis/clients/jedis/util/LazyRawable.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit ef21a05 into redis:master Jun 1, 2023
@sazzad16 sazzad16 deleted the rs-aggr-refactor branch June 1, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants