-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to ignore cluster init error #3455
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #3455 +/- ##
============================================
+ Coverage 71.31% 71.32% +0.01%
Complexity 4743 4743
============================================
Files 275 275
Lines 14740 14742 +2
Branches 993 994 +1
============================================
+ Hits 10512 10515 +3
+ Misses 3798 3796 -2
- Partials 430 431 +1
☔ View full report in Codecov by Sentry. |
I don't particularly want to add |
@yangbodong22011 It seems to be a big deal for spring-data-redis (check references), at least for some of the users. |
It's really not easy to deal with, let's hear @kableprime opinion on this PR. |
I agree with @yangbodong22011 that we shouldn't have to handle this. Let's let it bake for a bit... It sounds like fixing this library do to an issue there - ideally the fix would be in the downstream library. But as this is optional, for users who require it, voting with @sazzad16 But I think we should document this. |
@chayim I'm thinking here https://github.com/redis/jedis/wiki/FAQ. WDYT? |
The init error is suppressed by the option. But will it work normally afterwards? what is meaning by "failed cluster initialization". My use case: All tries had the error while the Cluster seems up and stable. |
To be exact, the init error can be suppressed by the option.
No.
(Mostly) Not being able to connect to any of the nodes and fetch cluster information. |
References of inspiration:
A
JedisClusterOperationException
with messageCould not initialize cluster slots cache.
is thrown during failed cluster initialization. This behavior is introduced since Jedis 4.0.0. To avoid this error, just setjedis.cluster.initNoError
(any value) system property.