-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use List<KeyValue> to read RESP3 Map reply #3456
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #3456 +/- ##
============================================
- Coverage 71.30% 71.19% -0.12%
+ Complexity 4745 4740 -5
============================================
Files 275 275
Lines 14740 14824 +84
Branches 990 1017 +27
============================================
+ Hits 10511 10554 +43
- Misses 3800 3830 +30
- Partials 429 440 +11
☔ View full report in Codecov by Sentry. |
When implementing RESP3, I converted the Redis Map reply (map{k1->v1, k2->v2, ...}) to simple flat array (list{k1, v1, k2, v2, ...}).
In this PR, I have converted the Map reply to array of KeyValues (list{ kv{k1, v1}, kv{k2, v2}, ...}).
As a by-product of this PR, some commands were found where the return can/should be a Map instead of a List.