Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use List<KeyValue> to read RESP3 Map reply #3456

Merged
merged 14 commits into from
Jun 11, 2023

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Jun 4, 2023

When implementing RESP3, I converted the Redis Map reply (map{k1->v1, k2->v2, ...}) to simple flat array (list{k1, v1, k2, v2, ...}).
In this PR, I have converted the Map reply to array of KeyValues (list{ kv{k1, v1}, kv{k2, v2}, ...}).

As a by-product of this PR, some commands were found where the return can/should be a Map instead of a List.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch coverage: 83.00% and project coverage change: -0.12 ⚠️

Comparison is base (7331a7b) 71.30% compared to head (872ee0b) 71.19%.

❗ Current head 872ee0b differs from pull request most recent head 849f115. Consider uploading reports for the commit 849f115 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3456      +/-   ##
============================================
- Coverage     71.30%   71.19%   -0.12%     
+ Complexity     4745     4740       -5     
============================================
  Files           275      275              
  Lines         14740    14824      +84     
  Branches        990     1017      +27     
============================================
+ Hits          10511    10554      +43     
- Misses         3800     3830      +30     
- Partials        429      440      +11     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Module.java 33.33% <ø> (ø)
...dis/clients/jedis/resps/AccessControlLogEntry.java 87.09% <ø> (ø)
...a/redis/clients/jedis/resps/AccessControlUser.java 46.15% <44.44%> (-35.99%) ⬇️
...ava/redis/clients/jedis/resps/CommandDocument.java 40.90% <57.89%> (-59.10%) ⬇️
.../java/redis/clients/jedis/resps/FunctionStats.java 87.87% <80.95%> (-5.88%) ⬇️
...nts/jedis/timeseries/TimeSeriesBuilderFactory.java 85.71% <82.35%> (+0.20%) ⬆️
...in/java/redis/clients/jedis/resps/LibraryInfo.java 92.10% <86.36%> (-7.90%) ⬇️
.../main/java/redis/clients/jedis/BuilderFactory.java 77.45% <89.92%> (+2.02%) ⬆️
src/main/java/redis/clients/jedis/Protocol.java 90.60% <91.66%> (+1.10%) ⬆️
.../main/java/redis/clients/jedis/CommandObjects.java 85.74% <100.00%> (-0.03%) ⬇️
... and 4 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance labels Jun 11, 2023
@sazzad16 sazzad16 merged commit 7a68df8 into redis:master Jun 11, 2023
@sazzad16 sazzad16 deleted the keyvalue-for-map branch June 11, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants