Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RedisCredentials with HELLO command #3507

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Patch coverage: 75.67% and no project coverage change.

Comparison is base (2c609cf) 71.15% compared to head (2c1acdd) 71.16%.

❗ Current head 2c1acdd differs from pull request most recent head ca48100. Consider uploading reports for the commit ca48100 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3507   +/-   ##
=========================================
  Coverage     71.15%   71.16%           
+ Complexity     4768     4763    -5     
=========================================
  Files           278      278           
  Lines         15017    15014    -3     
  Branches       1056     1057    +1     
=========================================
- Hits          10685    10684    -1     
+ Misses         3867     3863    -4     
- Partials        465      467    +2     
Files Changed Coverage Δ
src/main/java/redis/clients/jedis/Connection.java 80.68% <75.67%> (+2.29%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 added this to the 5.0.0 milestone Aug 19, 2023
Copy link
Collaborator

@yangbodong22011 yangbodong22011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sazzad16 sazzad16 merged commit 71204c5 into redis:master Aug 21, 2023
@sazzad16 sazzad16 deleted the credentials-hello branch August 21, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants