Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in SetPipelineCommands method name #3773

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix typo in SetPipelineCommands method name #3773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28745a
Fix typo in SetPipelineCommands method name
gerzse Mar 15, 2024
ccf1367
Refine javadoc for the deprecated method
gerzse Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/redis/clients/jedis/PipeliningBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ public Response<Set<String>> sdiff(String... keys) {
}

@Override
public Response<Long> sdiffStore(String dstKey, String... keys) {
public Response<Long> sdiffstore(String dstKey, String... keys) {
return appendCommand(commandObjects.sdiffstore(dstKey, keys));
}

Expand Down
9 changes: 8 additions & 1 deletion src/main/java/redis/clients/jedis/commands/SetPipelineCommands.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,14 @@ default Response<ScanResult<String>> sscan(String key, String cursor) {

Response<Set<String>> sdiff(String... keys);

Response<Long> sdiffStore(String dstKey, String... keys);
Response<Long> sdiffstore(String dstKey, String... keys);

/**
* @deprecated Use {@code redis.clients.jedis.commands.SetPipelineCommands#sdiffstore(java.lang.String, java.lang.String...)}
*/
default Response<Long> sdiffStore(String dstKey, String... keys) {
return sdiffstore(dstKey, keys);
}
gerzse marked this conversation as resolved.
Show resolved Hide resolved

Response<Set<String>> sinter(String... keys);

Expand Down
4 changes: 3 additions & 1 deletion src/test/java/redis/clients/jedis/ClusterPipeliningTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,8 @@ public void clusterPipelineSet() {
Response<Long> r1 = p.sadd("my{set}", "hello", "hello", "world", "foo", "bar");
p.sadd("mynew{set}", "hello", "hello", "world");
Response<Set<String>> r2 = p.sdiff("my{set}", "mynew{set}");
Response<Long> r3 = p.sdiffStore("diffset{set}", "my{set}", "mynew{set}");
Response<Long> r3deprecated = p.sdiffStore("diffset{set}deprecated", "my{set}", "mynew{set}");
Response<Long> r3 = p.sdiffstore("diffset{set}", "my{set}", "mynew{set}");
Response<Set<String>> r4 = p.smembers("diffset{set}");
Response<Set<String>> r5 = p.sinter("my{set}", "mynew{set}");
Response<Long> r6 = p.sinterstore("interset{set}", "my{set}", "mynew{set}");
Expand All @@ -547,6 +548,7 @@ public void clusterPipelineSet() {
p.sync();
assertEquals(Long.valueOf(4), r1.get());
assertEquals(diff, r2.get());
assertEquals(Long.valueOf(diff.size()), r3deprecated.get());
assertEquals(Long.valueOf(diff.size()), r3.get());
assertEquals(diff, r4.get());
assertEquals(inter, r5.get());
Expand Down
Loading