Implemented read-write separation based Sentinel #3797
+521
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
reviewed
Apr 3, 2024
There was a problem hiding this comment.
First of all thank you for using Jedis and for trying to improve it.
- The term slave is either removed or deprecated.
- Currently our focus is more towards UnifiedJedis (with the help of CommandExecutor, ConnectionProvider, etc.) compared to Jedis and Pool. So, at this moment, whether you implement this with Jedis and Pool or not, we prefer an implementation with UnifiedJedis.
- It would be great if this can be done in JedisSentineled with some configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented read-write separation function based on Redis Sentinel, balancing read request load to all slave, Support Redis high availability and failover.