Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ROLE command #664

Closed
wants to merge 2 commits into from
Closed

Support ROLE command #664

wants to merge 2 commits into from

Conversation

HeartSaVioR
Copy link
Contributor

@HeartSaVioR HeartSaVioR commented Jun 29, 2014 •
edited
Loading

  • http://redis.io/commands/role
  • available since 2.8.12
  • Output format differ from each of role
    • role: master, slave, sentinel
    • please see documentation for format details
  • unit test included

Please review and comment. Thanks!

This change is Reviewable

@HeartSaVioR
Support ROLE command available since 2.8.12
0caf1f7 
* http://redis.io/commands/role
* Output format differ from each of role
** role: master, slave, sentinel
** please see documentation for format details
* unit test included
@HeartSaVioR
Copy link
Contributor Author

Build is broken due to change from Redis unstable branch.
Details on redis/redis#1848.

@HeartSaVioR
Copy link
Contributor Author

I'm a bit confused to whether I should introduce data structure for ROLE command's result or not.
It's somewhat complex and users have to understand output format and parse it him/herself.
But when we present parser / result object, we need to follow up changes, and we will be getting stuck when many versions of output format exists.

@HeartSaVioR HeartSaVioR mentioned this pull request Jul 1, 2014
Merged
@HeartSaVioR HeartSaVioR added this to the 2.6.0 milestone Aug 30, 2014
@marcosnils
Copy link
Contributor

@HeartSaVioR and myself have decided to postpone a little bit this feature to implement a better interface. We'll provide an update soon and release for future 2.6.x versions.

@HeartSaVioR HeartSaVioR removed this from the 2.6.0 milestone Sep 10, 2014
@HeartSaVioR HeartSaVioR mentioned this pull request Oct 1, 2015
Closed
@aeter aeter mentioned this pull request Jan 13, 2019
Closed
@sazzad16 sazzad16 mentioned this pull request Jul 28, 2021
Merged
@sazzad16
Copy link
Collaborator

Resolved by #2607

@sazzad16 sazzad16 closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeartSaVioR @marcosnils @sazzad16