Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyArgs should honor replace parameter value instead of doing null check only #1777

Closed
christophstrobl opened this issue Jun 18, 2021 · 0 comments
Closed

CopyArgs should honor replace parameter value instead of doing null check only #1777

christophstrobl opened this issue Jun 18, 2021 · 0 comments
Labels
type: bug A general bug
Milestone
6.1.3

Comments

@christophstrobl
Copy link
Contributor

The if clause if(replace != null) in build(...) should not only check if the actual value is non null but also if it is true in order to add the RELACE.
@mp911de mp911de added the type: bug A general bug label Jun 18, 2021
mp911de added a commit that referenced this issue Jun 21, 2021
@mp911de
Fix CopyArgs rendering for REPLACE #1777
9774c2c 
Lettuce now correctly checks if the replace flag was set using a boolean check instead of non-null.
@mp911de mp911de added this to the 6.1.3 milestone Jun 21, 2021
mp911de added a commit that referenced this issue Jun 21, 2021
@mp911de
Fix CopyArgs rendering for REPLACE #1777
6b831f0 
Lettuce now correctly checks if the replace flag was set using a boolean check instead of non-null.
@mp911de mp911de closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
6.1.3
Development

No branches or pull requests
2 participants
@mp911de @christophstrobl