We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisURI.Builder#withSsl(RedisURI) does not copy SslVerifyMode setting properly if it is set to SslVerifyMode#CA.
RedisURI.Builder#withSsl(RedisURI)
SslVerifyMode
SslVerifyMode#CA
What it does instead is:
RedisURI#isVerifyPeer
true
RedisURI.Builder#withVerifyPeer(boolean)
SslVerifyMode.FULL
This logic is used in some internals of the lettuce itself (like RedisMasterReplicaNode class) which causes problems for us.
RedisMasterReplicaNode
Resulting state RedisURI.Builder should have SslVerifyMode#CA instead of SslVerifyMode#FULL
SslVerifyMode#FULL
Change the line in RedisURI.Builder#withSsl(io.lettuce.core.RedisURI) from
RedisURI.Builder#withSsl(io.lettuce.core.RedisURI)
withVerifyPeer(source.isVerifyPeer());
to
withVerifyPeer(source.getVerifyMode());
The text was updated successfully, but these errors were encountered:
Fix RedisURI.Builder.withSsl(…) to retain peer verification mode #2182
e5bc969
7aa64d1
ecc7880
No branches or pull requests
Bug Report
Current Behavior
RedisURI.Builder#withSsl(RedisURI)
does not copySslVerifyMode
setting properly if it is set toSslVerifyMode#CA
.What it does instead is:
RedisURI#isVerifyPeer
(which in case ofSslVerifyMode#CA
will result intrue
).RedisURI.Builder#withVerifyPeer(boolean)
which results inSslVerifyMode.FULL
being set instead ofSslVerifyMode#CA
.This logic is used in some internals of the lettuce itself (like
RedisMasterReplicaNode
class) which causes problems for us.Expected behavior/code
Resulting state RedisURI.Builder should have
SslVerifyMode#CA
instead ofSslVerifyMode#FULL
Possible Solution
Change the line in
RedisURI.Builder#withSsl(io.lettuce.core.RedisURI)
fromwithVerifyPeer(source.isVerifyPeer());
to
withVerifyPeer(source.getVerifyMode());
The text was updated successfully, but these errors were encountered: