Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisURI: improve deprecation notice in withPassword() #1707

Merged

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Apr 6, 2021

See #1695 (reply in thread) for context.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #1707 (cd91dde) into main (6637074) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1707      +/-   ##
============================================
+ Coverage     78.28%   78.31%   +0.03%     
- Complexity     6728     6732       +4     
============================================
  Files           507      507              
  Lines         22665    22665              
  Branches       2463     2463              
============================================
+ Hits          17744    17751       +7     
+ Misses         3774     3769       -5     
+ Partials       1147     1145       -2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/lettuce/core/RedisURI.java 92.17% <ø> (ø) 162.00 <0.00> (ø)
...main/java/io/lettuce/core/AbstractRedisClient.java 77.17% <0.00%> (-1.09%) 44.00% <0.00%> (-1.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 78.88% <0.00%> (-0.63%) 39.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.39% <0.00%> (+0.43%) 1.00% <0.00%> (ø%)
.../java/io/lettuce/core/protocol/CommandHandler.java 76.04% <0.00%> (+1.97%) 119.00% <0.00%> (+4.00%)
...e/core/masterreplica/SentinelTopologyProvider.java 83.78% <0.00%> (+2.70%) 10.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6637074...cd91dde. Read the comment docs.

@mp911de mp911de added the type: documentation A documentation update label Apr 7, 2021
@mp911de mp911de added this to the 6.0.4 milestone Apr 7, 2021
@mp911de mp911de merged commit 4df68a7 into redis:main Apr 7, 2021
mp911de added a commit that referenced this pull request Apr 7, 2021
Update documentation of the setter. Reformat code.
mp911de added a commit that referenced this pull request Apr 7, 2021
Update documentation of the setter. Reformat code.
mp911de added a commit that referenced this pull request Apr 7, 2021
Update documentation of the setter. Reformat code.
@mp911de
Copy link
Collaborator

mp911de commented Apr 7, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@perlun perlun deleted the fix/improve-withPassword-deprecation-notice branch April 7, 2021 07:35
@perlun
Copy link
Contributor Author

perlun commented Apr 7, 2021

@mp911de Thanks, appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants