Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisClusterNode: Validate that the RedisURI are equal when comparing nodes #1910

Closed
wants to merge 2 commits into from
Closed

RedisClusterNode: Validate that the RedisURI are equal when comparing nodes #1910

wants to merge 2 commits into from

Conversation

tmapes
Copy link

@tmapes tmapes commented Nov 2, 2021

For container based instances of Redis, where IP addresses can change, but other data about the node might not (like nodeId) ensure that the URI matches for every node.
Fixes #1909.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tmapes
Copy link
Author

tmapes commented Nov 2, 2021

I was not able to run the tests locally.
make test (and make start) error with the below.

[ ] Deallocating section [stunnel-master-slave-node-2]
[ ] Initializing inetd mode configuration
make[1]: *** [work/stunnel.pid] Error 1
make: *** [start] Error 2

I was also not able to run tests via Intellij and JDK 11.0.11 as after installing dependencies I received the below error.

Exception in thread "main" java.lang.NoClassDefFoundError: org/codehaus/plexus/util/InterpolationFilterReader
	at kr.motd.maven.os.DetectExtension.interpolate(DetectExtension.java:229)
	at kr.motd.maven.os.DetectExtension.interpolate(DetectExtension.java:207)
	at kr.motd.maven.os.DetectExtension.interpolate(DetectExtension.java:176)
	at kr.motd.maven.os.DetectExtension.interpolate(DetectExtension.java:165)
	at kr.motd.maven.os.DetectExtension.afterProjectsRead(DetectExtension.java:119)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:264)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:289)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:193)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
	at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
Caused by: java.lang.ClassNotFoundException: org.codehaus.plexus.util.InterpolationFilterReader
	at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
	at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
	at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
	at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
	... 20 more

Process finished with exit code 1

@tmapes tmapes closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoundRobinSocketAddressSupplier is not refreshing when RedisURI changes
1 participant