Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset round robin on cluster node RedisURI change #1912

Closed
wants to merge 1 commit into from

Conversation

langchristian96
Copy link

Fixes #1909

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@mp911de mp911de added the type: bug A general bug label Dec 3, 2021
@mp911de
Copy link
Collaborator

mp911de commented Dec 3, 2021

Thanks a lot. The collection size check can happen early on for an early return. We also should consider that the URI of a RedisClusterNode can be null. I'm going to polish up these aspects during the merge.

@mp911de mp911de added this to the 6.0.9 milestone Dec 3, 2021
@mp911de mp911de changed the title Reset round robin on node ip change Reset round robin on cluster node RedisURI change Dec 3, 2021
mp911de pushed a commit that referenced this pull request Dec 3, 2021
mp911de added a commit that referenced this pull request Dec 3, 2021
Refactor BiFunction to isEqual BiPredicate. Return early if collection sizes do not match. Add tests and revise RedisClusterNode tests to verify equality and hashcode behavior.

Original pull request: #1912.
mp911de pushed a commit that referenced this pull request Dec 3, 2021
mp911de added a commit that referenced this pull request Dec 3, 2021
Refactor BiFunction to isEqual BiPredicate. Return early if collection sizes do not match. Add tests and revise RedisClusterNode tests to verify equality and hashcode behavior.

Original pull request: #1912.
mp911de pushed a commit that referenced this pull request Dec 3, 2021
mp911de added a commit that referenced this pull request Dec 3, 2021
Refactor BiFunction to isEqual BiPredicate. Return early if collection sizes do not match. Add tests and revise RedisClusterNode tests to verify equality and hashcode behavior.

Original pull request: #1912.
@mp911de
Copy link
Collaborator

mp911de commented Dec 3, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoundRobinSocketAddressSupplier is not refreshing when RedisURI changes
2 participants