Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate profile to support m1 chip #2043

Closed

Conversation

sokomishalov
Copy link
Collaborator

Create a separate maven profile to support compatibility between apple silicon chip (m1) and netty-tcnative libraries

@mp911de
Copy link
Collaborator

mp911de commented Mar 11, 2022

The underlying issue is that there are no arm/aarch versions of netty-tcnative?

@sokomishalov sokomishalov force-pushed the feature/m1-netty-native-support branch from 0a230ea to d9663ce Compare March 11, 2022 15:53
@sokomishalov
Copy link
Collaborator Author

sokomishalov commented Mar 11, 2022

@mp911de actually they should be already according to this issue since 2.0.42.Final.
But unfortunately maven cannot found them in the central repo:

[ERROR] Failed to execute goal on project lettuce-core: Could not resolve dependencies for project io.lettuce:lettuce-core:jar:6.2.0.BUILD-SNAPSHOT: io.netty:netty-tcnative:jar:osx-aarch_64:2.0.46.Final was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]

image

@sokomishalov
Copy link
Collaborator Author

@mp911de mp911de added this to the 6.1.7 milestone Mar 16, 2022
@mp911de mp911de added the type: task A general task label Mar 16, 2022
mp911de pushed a commit that referenced this pull request Mar 16, 2022
mp911de pushed a commit that referenced this pull request Mar 16, 2022
@mp911de
Copy link
Collaborator

mp911de commented Mar 16, 2022

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de closed this Mar 16, 2022
mp911de added a commit that referenced this pull request Mar 16, 2022
mp911de added a commit that referenced this pull request Mar 16, 2022
@sokomishalov sokomishalov deleted the feature/m1-netty-native-support branch March 16, 2022 10:22
@sokomishalov sokomishalov restored the feature/m1-netty-native-support branch March 18, 2022 11:42
@sokomishalov sokomishalov deleted the feature/m1-netty-native-support branch March 18, 2022 11:42
@sokomishalov sokomishalov restored the feature/m1-netty-native-support branch March 18, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants