Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AdaptiveRefreshTriggeredEvent to provide the cause and contextual details #2338

Closed
wants to merge 1 commit into from

Conversation

jacob-pro
Copy link
Contributor

What:

  • Adds trigger source to the AdaptiveRefreshTriggeredEvent class.
  • Adds debug logging for the event.
  • Adds missing event for the ASK_REDIRECT trigger (I'm assuming this was missing by mistake?).

Why:

I have recently been trying to debug excessive topology refreshes, and found it very difficult to find the root cause.

@mp911de
Copy link
Collaborator

mp911de commented Apr 18, 2023

Thanks a lot for your pull request. This looks neat and we're going to merge this one.

@mp911de mp911de added the type: feature A new feature label Apr 18, 2023
@mp911de mp911de changed the title Improve AdaptiveRefreshTriggeredEvent Improve AdaptiveRefreshTriggeredEvent to provide the cause and contextual details Apr 18, 2023
@mp911de mp911de added this to the 6.2.3.RELEASE milestone Apr 18, 2023
mp911de added a commit that referenced this pull request Apr 18, 2023
Add event subclasses for persistent reconnects and uncovered slots exposing the retry-counter/slot value.
mp911de added a commit that referenced this pull request Apr 18, 2023
Add event subclasses for persistent reconnects and uncovered slots exposing the retry-counter/slot value.
@mp911de
Copy link
Collaborator

mp911de commented Apr 18, 2023

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Apr 18, 2023
@mp911de mp911de modified the milestones: 6.2.3.RELEASE, 6.2.4.RELEASE Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants