Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_url() typed incorrectly #2971

Closed
fennb opened this issue Oct 1, 2023 · 2 comments
Closed

from_url() typed incorrectly #2971

fennb opened this issue Oct 1, 2023 · 2 comments

Comments

@fennb
Copy link

fennb commented Oct 1, 2023

Version: 5.0.1

Platform: All

Description: A recent commit that (very helpfully) introduced type hints to the library has an incorrect return type defined for Redis.from_url(). Notably, it declares a return type of None rather than Redis as it should be.

This was introduced in this commit: https://github.com/redis/redis-py/pull/2952/files#diff-3161b005adfa1f5266a9736bffb5ede9d14e2ab40937cb241bc16ca5647df79dR97

@mrtolkien
Copy link

Same issue here, this is pretty critical imo because it breaks any CI running linting with redis.

@dvora-h
Copy link
Collaborator

dvora-h commented Oct 9, 2023

Fixed in #2963

@dvora-h dvora-h closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants