Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Redis.from_url() return type #2994

Closed
wants to merge 1 commit into from

Conversation

davemcphee
Copy link
Contributor

@davemcphee davemcphee commented Oct 9, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • [√] Do tests and lints pass with this change?
  • [√] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

Fixes return type of Redis.from_url() (was None, now "Redis")

fixes #2971

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (787d731) 91.37% compared to head (5138805) 66.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2994       +/-   ##
===========================================
- Coverage   91.37%   66.57%   -24.81%     
===========================================
  Files         126      126               
  Lines       32608    32608               
===========================================
- Hits        29797    21710     -8087     
- Misses       2811    10898     +8087     
Files Coverage Δ
redis/client.py 65.50% <100.00%> (-26.48%) ⬇️

... and 81 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h
Copy link
Collaborator

dvora-h commented Oct 9, 2023

Fixed in #2963

@dvora-h dvora-h closed this Oct 9, 2023
@davemcphee davemcphee deleted the issue2971 branch November 15, 2023 03:32
@rafales
Copy link

rafales commented Nov 25, 2023

Why not type it as Self which works better with subclasses? I see that typing_extensions is in dependencies, so it can be used to support pre 3.11 versions of python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_url() typed incorrectly
4 participants