Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the ABSTTL option of the RESTORE command. #1423

Merged
merged 2 commits into from
Nov 22, 2020

Conversation

charettes
Copy link
Contributor

@charettes charettes commented Nov 22, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Does travis tests pass with this change (enable it first in your forked repo and wait for the travis build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

The ABSTTL option of the RESTORE command has been available since Redis 5.0. This PR adds an absttl=False kwarg to the restore command to allow enabling this option.

@codecov-io
Copy link

codecov-io commented Nov 22, 2020

Codecov Report

Merging #1423 (5abe08a) into master (8c176cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   86.58%   86.59%           
=======================================
  Files           6        6           
  Lines        2900     2902    +2     
=======================================
+ Hits         2511     2513    +2     
  Misses        389      389           
Impacted Files Coverage Δ
redis/client.py 87.02% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c176cd...5abe08a. Read the comment docs.

redis/client.py Outdated Show resolved Hide resolved
redis/client.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
@charettes charettes force-pushed the restore-absttl branch 2 times, most recently from 131a820 to 65faa97 Compare November 22, 2020 19:04
@charettes
Copy link
Contributor Author

@bmerry all comments should be addressed.

@andymccurdy
Copy link
Contributor

This looks great. Thanks!

@andymccurdy andymccurdy merged commit 1a41cfd into redis:master Nov 22, 2020
@charettes charettes deleted the restore-absttl branch November 22, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants