-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a count parameter to lpop/rpop for redis >= 6.2.0 #1487
Conversation
count
parameter to lpop/rpop
@wavenator Mind updating your branch with the latest master. CI has moved to GitHub actions, and the unit test were fixed. Happy to review when ready. |
@chayim Thanks for your reply. My tests have been fixed. One more test failed that wasn't mine. I appreciate your help with this. By the way, I hope you squash all my commits. |
@wavenator Looks great, and checks out against the lpop and rpop docs. I think the unit test failed because the client kill run (my change a while back!) didn't properly turf all connections. I'm going to play with this a bit more, to be sure - and re-run the action accordingly. |
I will be more than happy to help you if you need it! |
@wavenator I have a PR up, purely to update to the latest redis-docker (and fix client kill), which will hence pass yours. But, I uncovered a flaky test (this same one!) as my reminder. I've asked @AvitalFineRedis to fix the flaky test from her PR, so that I don't blindly merge my change. redis-py had a period of time where unit tests in master were failing, so my goal is to keep those, always passing - as first order. |
Validated with latest master, tests pass. @wavenator Thanks a tonne for your contribution, and patience in the back-and-forth. Much obliged! |
Add a count parameter to lpop/rpop for redis >= 6.2.0 (redis/redis-py#1487) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.