Use Version instead of StrictVersion since distutils is deprecated. #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tirkarthi Thanks a tonne for both reporting the issue, and fixing it. I'll be thrilled to see this in the upcoming redis-py release! |
Andrew-Chen-Wang
added a commit
to aio-libs-abandoned/aioredis-py
that referenced
this pull request
Oct 8, 2021
Use Version instead of StrictVersion since distutils is deprecated. (redis/redis-py#1552) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
|
So when the new version is released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Use Version instead of StrictVersion since distutils is deprecated. Ref : jamesls/fakeredis@ff1861c . I had run the tests with hiredis installed in tox and couldn't see any issues in tests. Migration : https://www.python.org/dev/peps/pep-0632/#migration-advice
Fixes #1551