Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support test with redis unstable docker #1850

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 4, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h requested a review from chayim January 4, 2022 08:38
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1850 (69c59bf) into master (231d402) will decrease coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1850      +/-   ##
==========================================
- Coverage   93.64%   93.60%   -0.05%     
==========================================
  Files          76       76              
  Lines       16207    16214       +7     
==========================================
  Hits        15177    15177              
- Misses       1030     1037       +7     
Impacted Files Coverage Δ
tests/conftest.py 89.63% <57.14%> (-1.06%) ⬇️
tests/test_search.py 98.78% <0.00%> (-0.25%) ⬇️
tests/test_cluster.py 98.66% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231d402...69c59bf. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jan 4, 2022
@chayim chayim changed the title Support test with unstable docker Support test with redis unstable docker Jan 4, 2022
@chayim chayim merged commit 15f315a into redis:master Jan 4, 2022
@dvora-h dvora-h deleted the test-unstable-redis branch January 4, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants