Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: Add project_urls for PyPI #1867

Merged
merged 1 commit into from
Jan 10, 2022
Merged

setup.py: Add project_urls for PyPI #1867

merged 1 commit into from
Jan 10, 2022

Conversation

tony
Copy link
Contributor

@tony tony commented Jan 6, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)? N/A
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? N/A
  • Is there an example added to the examples folder (if applicable)? N/A

Description of change

This adds project_urls to setup.py. They do not take effect until the package is published

Example:

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #1867 (afc1c6e) into master (15f315a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
+ Coverage   93.60%   93.62%   +0.02%     
==========================================
  Files          76       76              
  Lines       16214    16214              
==========================================
+ Hits        15177    15181       +4     
+ Misses       1037     1033       -4     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
tests/test_cluster.py 98.79% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f315a...afc1c6e. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jan 10, 2022
@chayim
Copy link
Contributor

chayim commented Jan 10, 2022

@tony Thank you for the change. You're bang on - we have some other places we should change this as well. Much obliged. Merging.

@chayim chayim self-requested a review January 10, 2022 08:18
@chayim chayim merged commit 1fbc2d1 into redis:master Jan 10, 2022
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Jan 11, 2022
@tony tony deleted the project-urls branch January 15, 2022 02:25
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants