Add type hints for JSON commands #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Feb 2, 2022
| """Return the memory usage in bytes of a value under ``path`` from | ||
| key ``name``. | ||
|
|
||
| For more information: https://oss.redis.com/redisjson/commands/#jsondebg | ||
| For more information: https://oss.redis.com/redisjson/commands/#jsondebug |
* add bzmpop * add comment * fix pr comment * fix linters * fix pr comments
* add zintercard * fix pr comment * linters
* add sort_ro * mark test as onlynon cluster * delete mark test as onlynoncluster * add eval_ro * fix linters * delete sort_ro * fix pr comment * add type hints * add type hints * linters
* add evalsha-ro * fix pr comment * add type hints * add type hints
* fix naming convention * fix worng changes
Codecov Report
@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
+ Coverage 92.99% 93.01% +0.01%
==========================================
Files 76 77 +1
Lines 16537 16541 +4
==========================================
+ Hits 15379 15385 +6
+ Misses 1158 1156 -2
Continue to review full report at Codecov.
|
chayim
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.