Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ACL DRYRUN #1992

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Add support for ACL DRYRUN #1992

merged 4 commits into from
Feb 16, 2022

Conversation

dogukanteber
Copy link
Contributor

Resolves #1963

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1992 (fe385e5) into master (e6ccc9c) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
- Coverage   93.07%   93.03%   -0.04%     
==========================================
  Files          77       77              
  Lines       16657    16665       +8     
==========================================
+ Hits        15504    15505       +1     
- Misses       1153     1160       +7     
Impacted Files Coverage Δ
tests/test_commands.py 99.26% <33.33%> (-0.14%) ⬇️
redis/commands/core.py 90.41% <50.00%> (-0.06%) ⬇️
tests/test_cluster.py 98.29% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ccc9c...fe385e5. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Feb 16, 2022

@dogukanteber Perfect PR, all in. Great unit tests, the whole deal. @dvora-h can you add this to CHANGES and merge it. Let's get this merged into 4.2.0rc1.

@chayim chayim assigned chayim and dvora-h and unassigned chayim Feb 16, 2022
@dvora-h dvora-h added feature New feature redis-7 labels Feb 16, 2022
@dvora-h dvora-h merged commit 9a1b00f into redis:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for missing command ACL DRYRUN
4 participants