Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async typing support to commands' returns #2010

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Some typing by @dvora-h didn't include the newly included async response typing.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #2010 (2dc9ebd) into master (afc83e1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   92.59%   92.61%   +0.01%     
==========================================
  Files         100      100              
  Lines       20909    20909              
==========================================
+ Hits        19361    19364       +3     
+ Misses       1548     1545       -3     
Impacted Files Coverage Δ
redis/commands/core.py 87.23% <100.00%> (ø)
redis/asyncio/client.py 90.63% <0.00%> (+0.17%) ⬆️
tests/test_search.py 99.11% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc83e1...2dc9ebd. Read the comment docs.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Andrew-Chen-Wang as always :). I pushed a small linter fix into your branch. I hope you don't mind!

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Feb 23, 2022
@Andrew-Chen-Wang
Copy link
Contributor Author

np at all. hopefully i can find a chance to add some typing to the sync side for redis, but no promises 😅 can't wait for those Optionals to go away with future annotations and a pyupgrade

@dvora-h dvora-h merged commit a77df17 into redis:master Mar 1, 2022
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the typing-core-1 branch March 2, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants