Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster support for functions #2016

Merged
merged 10 commits into from
Mar 6, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 23, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #2016 (66e5899) into master (98fd06e) will decrease coverage by 0.42%.
The diff coverage is 21.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   92.64%   92.22%   -0.43%     
==========================================
  Files         100      100              
  Lines       20953    20978      +25     
==========================================
- Hits        19411    19346      -65     
- Misses       1542     1632      +90     
Impacted Files Coverage Δ
redis/commands/cluster.py 94.87% <ø> (ø)
tests/test_function.py 25.30% <20.31%> (-74.70%) ⬇️
redis/cluster.py 91.93% <50.00%> (-0.11%) ⬇️
tests/conftest.py 87.60% <0.00%> (-2.00%) ⬇️
redis/commands/core.py 85.99% <0.00%> (-1.20%) ⬇️
redis/asyncio/connection.py 82.65% <0.00%> (-0.24%) ⬇️
tests/test_commands.py 99.27% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fd06e...66e5899. Read the comment docs.

@dvora-h dvora-h merged commit c4e4088 into redis:master Mar 6, 2022
dvora-h added a commit to dvora-h/redis-py that referenced this pull request Mar 6, 2022
* cluster support for functions

* fix test_list_on_cluster mark

* fix mark

* cluster unstable url

* fix

* fix cluster url

* skip tests

* linters

* linters
dvora-h added a commit that referenced this pull request Mar 6, 2022
* command docs

* Add support for AUTH (#1929)

* Add support for AUTH

* Fix linter error

* test fix

* fix test in cluster

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>

* Add support for JSON, TIMESERIES, BLOOM & GRAPH commands in cluster (#2032)

Co-authored-by: Chayim <chayim@users.noreply.github.com>

* Add support for HSET items (#2006)

* Add `items` parameter to `hset`

* Add test for `hset` with `items`

* Update CHANGES

* fix test_profile

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>

* Add cluster support for functions (#2016)

* cluster support for functions

* fix test_list_on_cluster mark

* fix mark

* cluster unstable url

* fix

* fix cluster url

* skip tests

* linters

* linters

* skip test

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: dogukanteber <47397379+dogukanteber@users.noreply.github.com>
Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: Marek Czaplicki <mdczaplicki@gmail.com>
@dvora-h dvora-h deleted the cluster-functions branch March 10, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants