Add support for EXPIREAT command's options #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
==========================================
- Coverage 92.17% 92.06% -0.12%
==========================================
Files 100 100
Lines 21024 21063 +39
==========================================
+ Hits 19379 19391 +12
- Misses 1645 1672 +27
Continue to review full report at Codecov.
|
chayim
reviewed
Mar 2, 2022
redis/commands/core.py
Outdated
| @@ -1501,16 +1501,28 @@ def expire(self, name: KeyT, time: ExpiryT) -> ResponseT: | |||
| time = int(time.total_seconds()) | |||
| return self.execute_command("EXPIRE", name, time) | |||
|
|
|||
| def expireat(self, name: KeyT, when: AbsExpiryT) -> ResponseT: | |||
| def expireat(self, name: KeyT, when: AbsExpiryT, option: str = None) -> ResponseT: | |||
There was a problem hiding this comment.
@dogukanteber WDYT about making these options (NX, XX, etc) variables in the function header. IMHO it would watch our other functions.
|
@dogukanteber I just pushed a small fix (I hope you don't mind!) so the options will be consistent with options in other functions (like set etc.), now it's ready and we'll include it in the next release, thank you! |
dvora-h
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
closes #1950