Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline support for Search #2038

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Mar 8, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #2038 (c015c2c) into master (a77df17) will decrease coverage by 0.43%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
- Coverage   92.60%   92.17%   -0.44%     
==========================================
  Files         100      100              
  Lines       20912    21024     +112     
==========================================
+ Hits        19365    19378      +13     
- Misses       1547     1646      +99     
Impacted Files Coverage Δ
redis/commands/search/commands.py 89.02% <71.42%> (-0.22%) ⬇️
redis/commands/search/__init__.py 85.00% <100.00%> (+3.18%) ⬆️
tests/test_search.py 99.13% <100.00%> (+0.01%) ⬆️
tests/test_function.py 25.30% <0.00%> (-74.70%) ⬇️
redis/commands/timeseries/__init__.py 94.73% <0.00%> (-5.27%) ⬇️
redis/commands/json/__init__.py 97.56% <0.00%> (-2.44%) ⬇️
redis/commands/parser.py 88.40% <0.00%> (-1.92%) ⬇️
redis/commands/core.py 85.86% <0.00%> (-1.37%) ⬇️
redis/cluster.py 91.93% <0.00%> (-0.51%) ⬇️
tests/test_commands.py 99.00% <0.00%> (-0.27%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77df17...c015c2c. Read the comment docs.

@dvora-h dvora-h added the feature New feature label Mar 8, 2022
@dvora-h dvora-h requested a review from chayim March 8, 2022 01:33
@@ -90,7 +92,25 @@ def __init__(self, client, index_name="idx"):

If conn is not None, we employ an already existing redis connection
"""
self.MODULE_CALLBACKS = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHHHH

@chayim chayim merged commit 5bf9034 into redis:master Mar 8, 2022
@dvora-h dvora-h deleted the search-pipeline branch March 8, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants