-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Vector Fields for Vector Similarity Search #2041
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2041 +/- ##
==========================================
+ Coverage 91.19% 91.21% +0.01%
==========================================
Files 100 100
Lines 21248 21319 +71
==========================================
+ Hits 19378 19447 +69
- Misses 1870 1872 +2
Continue to review full report at Codecov.
|
tests/test_search.py
Outdated
modclient.ft().create_index( | ||
( | ||
VectorField( | ||
"v", "HNSW", ["TYPE", "FLOAT32", "DIM", 2, "DISTANCE_METRIC", "L2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chayim Maybe it's better to pass the attributes as a dictionary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a bit clunky. I'd like to two do things before we merge:
- Try the dictionary approach (and document the kwargs)
- Add a jupyter notebook example.
WDYT @Avital-Fine ?
Can you add your example to examples.rst? (and test it locally) |
…to VecSim_ft.create
@Avital-Fine We want to merge it in before 4.2.0 release but the examples were broken so I moved them to a separate branch and after it will be fixed we will merged it too |
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.