Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use certificates from string in ssl connection #2048

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Mar 13, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2047

@dvora-h dvora-h added the feature New feature label Mar 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #2048 (b8383b3) into master (8d949a3) will decrease coverage by 0.08%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
- Coverage   92.17%   92.09%   -0.09%     
==========================================
  Files         100      100              
  Lines       21024    21064      +40     
==========================================
+ Hits        19378    19398      +20     
- Misses       1646     1666      +20     
Impacted Files Coverage Δ
redis/asyncio/client.py 90.45% <ø> (-0.18%) ⬇️
redis/client.py 89.39% <ø> (ø)
redis/cluster.py 91.93% <ø> (ø)
redis/asyncio/connection.py 82.63% <50.00%> (-0.02%) ⬇️
redis/connection.py 86.53% <100.00%> (+0.01%) ⬆️
tests/test_ssl.py 49.64% <100.00%> (+2.63%) ⬆️
redis/commands/cluster.py 92.68% <0.00%> (-2.19%) ⬇️
tests/test_cluster.py 97.38% <0.00%> (-0.92%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d949a3...b8383b3. Read the comment docs.

@@ -53,7 +53,7 @@ def test_ssl_connection_without_ssl(self, request):
r.ping()
assert "Connection closed by server" in str(e)

def test_validating_self_signed_certificate(self, request):
def test_validating_self_signed_file_certificate(self, request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't think you need to rename the test. But this PR is great. Approved.

@dvora-h dvora-h merged commit a12b5fd into redis:master Mar 14, 2022
@dvora-h dvora-h deleted the ssl-string-cert branch March 14, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to use certificates from string instead of file
3 participants