Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dialect support for RediSearch queries #2071

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Add dialect support for RediSearch queries #2071

merged 3 commits into from
Mar 31, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Mar 28, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2057

@dvora-h dvora-h added the feature New feature label Mar 28, 2022
@dvora-h dvora-h requested a review from chayim March 28, 2022 23:26
chayim
chayim approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future: we should use properties and refactor this class.

@dvora-h dvora-h merged commit bdae789 into redis:master Mar 31, 2022
@dvora-h dvora-h deleted the dialect branch May 9, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dialect support for RediSearch queries
2 participants
@dvora-h @chayim