Async tests for redis commands, json, bloom, timeseries #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
+ Coverage 91.22% 92.44% +1.22%
==========================================
Files 100 104 +4
Lines 21486 24364 +2878
==========================================
+ Hits 19601 22524 +2923
+ Misses 1885 1840 -45
Continue to review full report at Codecov.
|
chayim
reviewed
Apr 7, 2022
tests/test_asyncio/conftest.py
Outdated
| @@ -97,7 +99,8 @@ async def ateardown(): | |||
|
|
|||
|
|
|||
| @pytest_asyncio.fixture() | |||
| async def r(create_redis): | |||
| async def r(request, create_redis): | |||
| print(request.config.getoption("--redis-url")) | |||
There was a problem hiding this comment.
Please remove the print statement.
chayim
approved these changes
Apr 7, 2022
chayim
suggested changes
Apr 7, 2022
chayim
approved these changes
Apr 7, 2022
chayim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.