Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xtrim type annotation #2093

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Update xtrim type annotation #2093

merged 1 commit into from
Apr 27, 2022

Conversation

richli
Copy link
Contributor

@richli richli commented Apr 7, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

In xtrim(), the maxlen argument may be None if minid is specified, so its type annotation is updated to Union[int, None].

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #2093 (ab0b2a7) into master (20e4b87) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
- Coverage   91.22%   91.22%   -0.01%     
==========================================
  Files         100      100              
  Lines       21486    21486              
==========================================
- Hits        19601    19600       -1     
- Misses       1885     1886       +1     
Impacted Files Coverage Δ
redis/commands/core.py 82.85% <ø> (ø)
redis/asyncio/connection.py 82.75% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e4b87...ab0b2a7. Read the comment docs.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @richli !

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Apr 27, 2022
@dvora-h dvora-h merged commit 9e7e973 into redis:master Apr 27, 2022
@richli richli deleted the xtrim-maxlen-is-optional branch May 12, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants