-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retries in async mode #2180
Conversation
0c1fb6b
to
76f704d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2180 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 108 108
Lines 27393 27444 +51
=======================================
+ Hits 25200 25248 +48
- Misses 2193 2196 +3
Continue to review full report at Codecov.
|
This is ready for review. |
Any chance that my PR gets some consideration? It fixes a real bug. Is there anything I should do? |
@elemoine Thank you for the PR and for fixing the bug you reported.! Merging, and ensuring this is part of the 4.3.4 release. |
@dvora-h thank you! |
Description of change
The main goal of this PR is to fix retries in asyncio mode. As described on #2179, in asyncio mode, there are currently no retries on other errors than
TimeoutError
errors.To fix that bug the PR first makes the way retries are configured consistent in sync and async. It then modifies the
_disconnect_raise
function not to raise on any "supported error".Note: I think there are other problems with the retry configuration API, but for now I just wanted to fix the actual bug while making the retry configuration API consistent between sync and async.
Fixes #2179.
Pull Request check-list
$ tox
pass with this change (including linting)?Is there an example added to the examples folder (if applicable)?