Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query_params to FT.PROFILE #2198

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented May 24, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h requested a review from chayim May 24, 2022 09:04
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #2198 (4a54f41) into master (42b937f) will increase coverage by 0.03%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master    #2198      +/-   ##
==========================================
+ Coverage   91.99%   92.02%   +0.03%     
==========================================
  Files         108      108              
  Lines       27393    27647     +254     
==========================================
+ Hits        25200    25442     +242     
- Misses       2193     2205      +12     
Impacted Files Coverage Δ
redis/commands/search/commands.py 89.07% <87.50%> (+0.48%) ⬆️
tests/test_search.py 99.21% <100.00%> (+0.01%) ⬆️
redis/cluster.py 90.00% <0.00%> (-0.42%) ⬇️
tests/test_asyncio/test_search.py 98.35% <0.00%> (-0.33%) ⬇️
tests/test_cluster.py 96.90% <0.00%> (-0.12%) ⬇️
redis/commands/core.py 82.95% <0.00%> (-0.02%) ⬇️
redis/sentinel.py 86.16% <0.00%> (ø)
tests/test_json.py 100.00% <0.00%> (ø)
redis/connection.py 86.36% <0.00%> (ø)
tests/test_encoding.py 98.75% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b937f...4a54f41. Read the comment docs.

@@ -506,16 +508,17 @@ def _get_aggregate_result(self, raw, query, has_cursor):

return AggregateResult(rows, cursor, schema)

def profile(self, query, limited=False):
def profile(self, query, limited=False, query_params=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're already here can we add type hints to this function

@dvora-h dvora-h merged commit 7880460 into redis:master Jun 1, 2022
@dvora-h dvora-h deleted the profile-query-params branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants