-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query_params
to FT.PROFILE
#2198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
==========================================
+ Coverage 91.99% 92.02% +0.03%
==========================================
Files 108 108
Lines 27393 27647 +254
==========================================
+ Hits 25200 25442 +242
- Misses 2193 2205 +12
Continue to review full report at Codecov.
|
redis/commands/search/commands.py
Outdated
@@ -506,16 +508,17 @@ def _get_aggregate_result(self, raw, query, has_cursor): | |||
|
|||
return AggregateResult(rows, cursor, schema) | |||
|
|||
def profile(self, query, limited=False): | |||
def profile(self, query, limited=False, query_params=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're already here can we add type hints to this function
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.