Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dynamic_startup_nodes default value to 'True' #2251

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

barshaul
Copy link
Contributor

@barshaul barshaul commented Jun 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Changed dynamic_startup_nodes default value to 'True' to prevent breaking backward compatibility

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #2251 (835e65d) into master (63cf7ec) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
- Coverage   91.87%   91.82%   -0.05%     
==========================================
  Files         108      108              
  Lines       27786    27786              
==========================================
- Hits        25528    25515      -13     
- Misses       2258     2271      +13     
Impacted Files Coverage Δ
redis/cluster.py 90.33% <ø> (ø)
tests/test_asyncio/test_cluster.py 97.09% <0.00%> (-0.49%) ⬇️
tests/test_cluster.py 96.85% <0.00%> (-0.24%) ⬇️
redis/asyncio/connection.py 83.84% <0.00%> (-0.23%) ⬇️
tests/test_graph.py 90.65% <0.00%> (-0.04%) ⬇️
tests/test_timeseries.py 100.00% <0.00%> (ø)
tests/conftest.py 86.50% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63cf7ec...835e65d. Read the comment docs.

@barshaul barshaul marked this pull request as ready for review June 27, 2022 09:52
@dvora-h dvora-h merged commit 11cf66a into redis:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants