UnitTest for blocking PubSub auto-reconnect #2256
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?_NOTE: Maybe this requires us to clarify the API, for it appears to be the intention that connections are automatically re-established.
Description of change
Issue #2089 is about automatic reconnection in async PubSub.
This PR adds unittests verifying how the connection in the synchronous PubSub will automatically reconnect.
The caller needs merely catch redis.ConnectionError and then retry the read operations and a new connection
will be established.
Two tests are provided, one which calls
disconnect()
on the underlying connection (and does not raise an error in thereader) and one which mocks a
socket.error
coming out of thesocket.recv()
call.