Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings and resource usage problems in asyncio unittests #2258

Merged
merged 13 commits into from
Jul 26, 2022
Merged

Fix warnings and resource usage problems in asyncio unittests #2258

merged 13 commits into from
Jul 26, 2022

Commits on Jul 25, 2022

  1. Use pytest-asyncio in auto mode 

    Remove overly genereric `pytestmark=pytest.mark.asyncio` causing lots of warning noise
    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    3b01dbd View commit details
    Browse the repository at this point in the history

  2. Use "Factories as Fixtures" test pattern for the create_redis fixture 

    this fixture is now async, avoiding teardown problems with missing event loops.
    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    451ac03 View commit details
    Browse the repository at this point in the history

  3. Fix sporadic error on fast event loops, such as --uvloop

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1a1c0d7 View commit details
    Browse the repository at this point in the history

  4. Close connection, even if "username" was in kwargs 

    This fixes a resource usage warning in the async unittests.
    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    56bc4a1 View commit details
    Browse the repository at this point in the history

  5. Do async cleanup of acl passwords via a fixture

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    8d26c91 View commit details
    Browse the repository at this point in the history

  6. Remove unused import, fix whitespace

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    ea68f78 View commit details
    Browse the repository at this point in the history

  7. Fix test with missing "await"

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    c745185 View commit details
    Browse the repository at this point in the history

  8. Close pubsub objects after use in unittest 

    Use a simple fixture where possible, otherwise manually call pubsub.close()
    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    a69d73a View commit details
    Browse the repository at this point in the history

  9. re-introduce pytestmark=pytest.mark.asyncio for python 3.6

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    f2c100c View commit details
    Browse the repository at this point in the history

  10. Use context manager to clean up connections in connection pool for un… 

    …it tests
    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    d7ca47f View commit details
    Browse the repository at this point in the history

  11. Provide asynccontextmanager for python 3.6

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    011b76b View commit details
    Browse the repository at this point in the history

  12. make test_late_subscribe() more robuste

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    7b6a03c View commit details
    Browse the repository at this point in the history

  13. Catch a couple of additional leaked resources

    @kristjanvalur
    kristjanvalur committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    f48c733 View commit details
    Browse the repository at this point in the history