Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.6 support #2306

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Drop python 3.6 support #2306

merged 1 commit into from
Jul 27, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jul 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added maintenance Maintenance (CI, Releases, etc) breakingchange API or Breaking Change labels Jul 27, 2022
@dvora-h dvora-h requested a review from chayim July 27, 2022 12:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #2306 (5a34451) into master (f665bd3) will decrease coverage by 0.03%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master    #2306      +/-   ##
==========================================
- Coverage   92.05%   92.01%   -0.04%     
==========================================
  Files         109      109              
  Lines       28134    28061      -73     
==========================================
- Hits        25899    25821      -78     
- Misses       2235     2240       +5     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
tests/test_asyncio/test_bloom.py 99.54% <ø> (-0.01%) ⬇️
tests/test_asyncio/test_connection.py 98.50% <ø> (-0.07%) ⬇️
tests/test_asyncio/test_monitor.py 90.74% <ø> (-0.49%) ⬇️
tests/test_asyncio/test_pipeline.py 100.00% <ø> (ø)
tests/test_asyncio/test_search.py 98.34% <ø> (-0.34%) ⬇️
tests/test_asyncio/test_timeseries.py 100.00% <ø> (ø)
redis/asyncio/cluster.py 90.28% <50.00%> (ø)
redis/asyncio/connection.py 85.66% <60.00%> (+0.20%) ⬆️
redis/asyncio/lock.py 99.09% <100.00%> (-0.04%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f665bd3...5a34451. Read the comment docs.

@utkarshgupta137
Copy link
Contributor

Can you also remove asyncio.ensure_future in favour of asyncio.create_task

@dvora-h dvora-h merged commit 607a59a into redis:master Jul 27, 2022
@dvora-h
Copy link
Collaborator Author

dvora-h commented Jul 27, 2022

@utkarshgupta137 I missed your comment by 30 seconds... will do in a separate PR

@dvora-h dvora-h deleted the drop-3.6 branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants