Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TDIGEST.QUANTILE extensions #2317

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2197

@dvora-h dvora-h added feature New feature breakingchange API or Breaking Change labels Aug 2, 2022
@dvora-h dvora-h requested a review from chayim August 2, 2022 12:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #2317 (4dd1cd4) into master (fd9fea6) will increase coverage by 0.02%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
+ Coverage   92.13%   92.15%   +0.02%     
==========================================
  Files         110      111       +1     
  Lines       28650    28659       +9     
==========================================
+ Hits        26397    26412      +15     
+ Misses       2253     2247       -6     
Impacted Files Coverage Δ
redis/commands/core.py 82.11% <83.33%> (-0.01%) ⬇️
redis/commands/bf/__init__.py 100.00% <100.00%> (ø)
redis/commands/bf/commands.py 98.86% <100.00%> (ø)
redis/commands/bf/utils.py 100.00% <100.00%> (ø)
tests/test_asyncio/test_bloom.py 99.55% <100.00%> (+0.01%) ⬆️
tests/test_asyncio/test_commands.py 98.38% <100.00%> (-0.01%) ⬇️
tests/test_bloom.py 99.57% <100.00%> (+0.01%) ⬆️
tests/test_commands.py 89.81% <100.00%> (ø)
redis/asyncio/connection.py 86.11% <0.00%> (+0.11%) ⬆️
tests/test_cluster.py 96.96% <0.00%> (+0.11%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@dvora-h dvora-h merged commit 9901c79 into redis:master Aug 2, 2022
dvora-h added a commit that referenced this pull request Nov 21, 2022
* Add support for TDIGEST.QUANTILE extensions

* linters

* linters & utils

* Update test_bloom.py
@dvora-h dvora-h deleted the tdigest-quantile branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TDIGEST.QUANTILE extensions
3 participants