Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WITHSUFFIXTRIE to FT.CREATE #2324

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 4, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2301

redis/commands/search/field.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #2324 (e3ad97c) into master (34f07a7) will decrease coverage by 13.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2324       +/-   ##
===========================================
- Coverage   92.18%   79.12%   -13.07%     
===========================================
  Files         111      111               
  Lines       28713    28751       +38     
===========================================
- Hits        26469    22748     -3721     
- Misses       2244     6003     +3759     
Impacted Files Coverage Δ
redis/commands/search/field.py 98.64% <100.00%> (+0.07%) ⬆️
tests/test_asyncio/test_search.py 98.75% <100.00%> (+0.35%) ⬆️
tests/test_search.py 99.23% <100.00%> (+0.01%) ⬆️
tests/test_cluster.py 18.58% <0.00%> (-78.50%) ⬇️
tests/test_asyncio/test_cluster.py 18.88% <0.00%> (-78.40%) ⬇️
redis/asyncio/cluster.py 16.52% <0.00%> (-73.77%) ⬇️
redis/cluster.py 18.81% <0.00%> (-71.04%) ⬇️
redis/asyncio/parser.py 17.30% <0.00%> (-63.47%) ⬇️
redis/commands/cluster.py 37.57% <0.00%> (-56.07%) ⬇️
redis/crc.py 45.45% <0.00%> (-54.55%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h merged commit 2cea637 into redis:master Aug 4, 2022
dvora-h added a commit that referenced this pull request Nov 21, 2022
* withsuffixtrie

* Update test_search.py

* fix
@dvora-h dvora-h deleted the withsuffixtrie branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for WITHSUFFIXTRIE to FT.CREATE
3 participants