Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Redis(single_connection_client) #2327

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

povilasb
Copy link
Contributor

@povilasb povilasb commented Aug 8, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?
    WON'T DO: too insignificant.

Description of change

I spent a significant portion of time debugging concurrency issues not knowing that Redis is not thread safe with single_connection_client=True.
Found this comment on GitHub issues: #1426 (comment)
Hopefully will save the trouble for others :)

@povilasb povilasb marked this pull request as ready for review August 8, 2022 13:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #2327 (a8a1166) into master (2cea637) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
- Coverage   92.21%   92.18%   -0.03%     
==========================================
  Files         111      111              
  Lines       28751    28751              
==========================================
- Hits        26513    26505       -8     
- Misses       2238     2246       +8     
Impacted Files Coverage Δ
redis/client.py 89.06% <ø> (ø)
tests/conftest.py 84.94% <0.00%> (-0.78%) ⬇️
tests/test_asyncio/test_search.py 98.43% <0.00%> (-0.32%) ⬇️
tests/test_cluster.py 96.85% <0.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 29, 2022
@dvora-h dvora-h merged commit 0b27e3e into redis:master Aug 29, 2022
@povilasb povilasb deleted the important-docs branch August 30, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants