Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tdigest.create #2348

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Fix tdigest.create #2348

merged 1 commit into from
Aug 21, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 21, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #2348 (2e62743) into master (2cea637) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2348      +/-   ##
==========================================
- Coverage   92.21%   92.18%   -0.04%     
==========================================
  Files         111      111              
  Lines       28751    28751              
==========================================
- Hits        26513    26503      -10     
- Misses       2238     2248      +10     
Impacted Files Coverage Δ
redis/commands/bf/commands.py 98.37% <100.00%> (ø)
tests/conftest.py 84.94% <0.00%> (-0.78%) ⬇️
tests/test_asyncio/test_search.py 98.43% <0.00%> (-0.32%) ⬇️
tests/test_cluster.py 96.85% <0.00%> (-0.24%) ⬇️
tests/test_asyncio/test_cluster.py 97.28% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h requested a review from chayim August 21, 2022 08:42
@dvora-h dvora-h merged commit e95b05a into redis:master Aug 21, 2022
@dvora-h dvora-h deleted the tdigest-create branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants