Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint annotations of expire time #2361

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

lucas-six
Copy link
Contributor

@lucas-six lucas-six commented Aug 26, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

ExpiryT includes float type, but params of expiry-time (ex, px) for methods such as set, setex, expire, pexpire, pesetex, getex, etc. , should be int, not float.

So we should replace float with int for ExpireT.

`ExpiryT` includes `float` type, but params of expiry-time (`ex`, `px`) for methods such as `set`, `expire`, `setnx`, etc. , should be `int`, not `float`.
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #2361 (01d5104) into master (ab5d407) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2361      +/-   ##
==========================================
- Coverage   92.21%   92.20%   -0.01%     
==========================================
  Files         111      111              
  Lines       28782    28782              
==========================================
- Hits        26540    26538       -2     
- Misses       2242     2244       +2     
Impacted Files Coverage Δ
redis/typing.py 86.48% <100.00%> (ø)
tests/test_cluster.py 96.96% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lucas-six
Copy link
Contributor Author

reopen PR for re-running checks.

@lucas-six lucas-six closed this Aug 26, 2022
@lucas-six lucas-six reopened this Aug 26, 2022
@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 29, 2022
@dvora-h dvora-h changed the title fix typehint annotations of expire time. Fix type hint annotations of expire time Aug 29, 2022
@dvora-h dvora-h merged commit fb54bdd into redis:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants