-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate Codecov in CI #2394
Reinstate Codecov in CI #2394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just uncomment lines 84-88?
Codecov ReportBase: 92.24% // Head: 92.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2394 +/- ##
==========================================
- Coverage 92.24% 92.11% -0.13%
==========================================
Files 111 110 -1
Lines 28814 28881 +67
==========================================
+ Hits 26579 26605 +26
- Misses 2235 2276 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Because the commented lines above it were/are on the wrong indent level, and it was hard to see the correct indentation without moving the block. Also, the execution order of the "show results" action and this don't really matter. This also changes the action version to v3, and removes the token line, so the diff is probably about the same size regardless. |
c70c61b
to
9b77ee0
Compare
9b77ee0
to
f668140
Compare
The execution order really doesn't matter, but:
|
Well, sure, I can put it back. 🤷
Because this is a public/OSS repository, and public repositories don't need tokens on Codecov. |
Since this is a public project, the token shouldn't be necessary
f668140
to
d0eaa17
Compare
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?Description of change
This PR:
codecov
CI action that was removed in Add support for new TDIGEST features and changes #2392 (321c57f).