Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch OSError on asyncio #2412

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix: catch OSError on asyncio #2412

merged 1 commit into from
Oct 25, 2022

Conversation

hyeongguen-song
Copy link
Contributor

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

Before redis-py support asyncio, #1832 merged to master
#1832 (comment)
So, asyncio to catch OSError too

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Base: 92.19% // Head: 92.19% // No change to project coverage 👍

Coverage data is based on head (aa0ae68) compared to base (aa0ae68).
Patch has no changes to coverable lines.

❗ Current head aa0ae68 differs from pull request most recent head 9a5fbb1. Consider uploading reports for the commit 9a5fbb1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2412   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         110      110           
  Lines       28889    28889           
=======================================
  Hits        26635    26635           
  Misses       2254     2254           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hyeongguen-song
Copy link
Contributor Author

@dvora-h could you review this pr?

@dvora-h
Copy link
Collaborator

dvora-h commented Oct 24, 2022

@hyeongguen-song Thanks for this fix!

@dvora-h dvora-h merged commit bea00b1 into redis:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants