Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: redismodules.rst fix #2429

Merged
merged 2 commits into from
Oct 25, 2022
Merged

doc: redismodules.rst fix #2429

merged 2 commits into from
Oct 25, 2022

Conversation

ashikshezan
Copy link
Contributor

@ashikshezan ashikshezan commented Oct 25, 2022

Parentheses were not closed

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Parentheses were not closed
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Oct 25, 2022
@chayim
Copy link
Contributor

chayim commented Oct 25, 2022

Thanks @ashikshezan for the contribution!

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 78.91% // Head: 92.04% // Increases project coverage by +13.13% 🎉

Coverage data is based on head (e82141c) compared to base (4200d54).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2429       +/-   ##
===========================================
+ Coverage   78.91%   92.04%   +13.13%     
===========================================
  Files         110      110               
  Lines       28735    28735               
===========================================
+ Hits        22675    26448     +3773     
+ Misses       6060     2287     -3773     
Impacted Files Coverage Δ
tests/test_asyncio/test_search.py 98.26% <0.00%> (-0.35%) ⬇️
redis/commands/core.py 82.17% <0.00%> (+0.16%) ⬆️
redis/asyncio/client.py 92.22% <0.00%> (+0.17%) ⬆️
tests/test_commands.py 89.92% <0.00%> (+0.18%) ⬆️
tests/test_json.py 100.00% <0.00%> (+0.19%) ⬆️
tests/test_asyncio/test_json.py 100.00% <0.00%> (+0.24%) ⬆️
redis/connection.py 86.30% <0.00%> (+0.48%) ⬆️
tests/test_lock.py 100.00% <0.00%> (+0.49%) ⬆️
tests/test_asyncio/test_lock.py 100.00% <0.00%> (+0.52%) ⬆️
redis/asyncio/sentinel.py 87.57% <0.00%> (+0.62%) ⬆️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h merged commit 9d70719 into redis:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants