Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up asyncio examples. #2431

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Tidy up asyncio examples. #2431

merged 1 commit into from
Oct 29, 2022

Conversation

Dreamsorcerer
Copy link
Contributor

Fixes #2419.

I haven't received any feedback to suggest there is a reason for these oddities, so here are the suggested changes to the asyncio examples.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 92.03% // Head: 91.99% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (34d3659) compared to base (bea00b1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
- Coverage   92.03%   91.99%   -0.05%     
==========================================
  Files         110      110              
  Lines       28737    28737              
==========================================
- Hits        26448    26436      -12     
- Misses       2289     2301      +12     
Impacted Files Coverage Δ
tests/test_cluster.py 96.62% <0.00%> (-0.35%) ⬇️
tests/test_asyncio/test_cluster.py 96.95% <0.00%> (-0.34%) ⬇️
redis/asyncio/connection.py 87.01% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim added hacktoberfest-accepted maintenance Maintenance (CI, Releases, etc) labels Oct 26, 2022
@dvora-h dvora-h merged commit 8a5c470 into redis:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asyncio examples
4 participants