Commits on Apr 21, 2023

1. Fix potential race condition during disconnection …

   When the disconnect() function is called twice in parallel it is possible that
   one thread deletes the self._sock reference, while the other thread will
   attempt to call .close() on it, leading to an AttributeError.
   
   This situation can routinely be encountered by closing the connection in a
   PubSubWorkerThread error handler in a blocking thread (ie. with
   sleep_time==None), and then calling .close() on the PubSub object.
   The main thread will then run into the disconnect() function, and the listener
   thread is woken up by the closure and will race into the disconnect()
   function, too.
   
   This can be fixed easily by copying the object reference before doing the
   None-check, similar to what we do in the redis.client.close() function.

   

   Anthchirp committed Apr 21, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 3053abc
   • Browse repository at this point

   Copy the full SHA

   3053abc View commit details

   Browse the repository at this point in the history