Support timeout = 0 in search query #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RediSearch query timeout = 0 means unlimited timeout. In the current implementation, the query timeout is only updated `if timeout` which in case of 0, translates to false. Since the default timeout of the `query` class is None, replacing the condition with `if self._timeout is not None` will also work for 0. If the parameter is not a positive integer, redis server will raise an exception. related issue: redis#2928 redis#2839
dvora-h
approved these changes
Sep 12, 2023
chayim
reviewed
Sep 12, 2023
Raise the exception when the timeout is set instead of when the query is performed
GuyAv46
reviewed
Sep 12, 2023
dvora-h
approved these changes
Sep 14, 2023
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2934 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.01%
==========================================
Files 126 126
Lines 32398 32400 +2
==========================================
- Hits 29575 29574 -1
- Misses 2823 2826 +3
☔ View full report in Codecov by Sentry. |
|
closes #2839 |
dvora-h
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RediSearch query timeout = 0 means unlimited timeout. In the current implementation, the query timeout is only updated
if timeoutwhich in case of 0, translates to false. Since the default timeout of thequeryclass is None, replacing the condition withif self._timeout is not Nonewill also work for 0. If the parameter is not a positive integer, redis server will raise an exception.related issue: #2839
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.