Python 3.12 #2979
Merged
Python 3.12 #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MagicStack/uvloop#567 is a precursor |
|
Today, |
|
Any news on this PR? |
|
Folks, I straight up forgot about this. We're getting it into the 5.1 beta with the removal of Python 3.7 too. @dvora-h leaving this with you. |
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2979 +/- ##
==========================================
- Coverage 92.05% 92.05% -0.01%
==========================================
Files 128 128
Lines 33195 33199 +4
==========================================
+ Hits 30558 30560 +2
- Misses 2637 2639 +2 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@adamantike thanks, used that.. but have an SSL context issue within the asyncio side. Are you familiar with this at all? |
|
Part of redis/hiredis-py#167 |
|
fyi, 3.12 also removes |
Fix checking of module versions. Remove logger from a test, it's just noise in the output. Fix cluster address remap test.
The plugin does not work like this for forked repos.
Speed up the computation for slots when initializing a cluster. After profiling, this turned out to be very slow, when it does not have to be. Do profiling a bit differently, via pytest.
Unlock urllib version, to be able to use more recent pytest versions.
vladvildanov
approved these changes
Jul 10, 2024
agnesnatasya
pushed a commit
to agnesnatasya/redis-py
that referenced
this pull request
Jul 20, 2024
Add support for Python 3.12. This required a bunch of changes all over the place, listed below in a random order. Fix tests, especially around SSL connections. Stop requiring typing-extensions. Enable tracemalloc for tests, and add the possibility to run the tests with profiling enabled. Fix some issues identified by tracemalloc, like sockets not being closed in case of SSL handshake failures. Remove the CI test reporting plugin, it does not work easily with forked repos anyway. Fix checking of module versions, make the comparison accurate. Not sure how it worked before, but it looks like it did not match exactly the format in the server INFO response, i.e. MMmmPP. Remove loggers from tests, it's just noise in the output. If we don't use asserts, nobody will check the log output from CI. Speed up the computation for slots when initializing a cluster. After profiling, this turned out to be very slow, when it does not have to be. It does not make sense to recompute the same thing over and over in a loop. Run uvloop tests in matrix, i.e. don't bundle two tests executions (without uvloop and with it) in the same job. Easier to spot failures like this, and arguably the jobs can be scheduled in parallel so the overall execution is faster. Unlock urllib version, to be able to use more recent pytest versions. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Add support for Python 3.12. This required a bunch of changes all over the place, listed below in a random order. Fix tests, especially around SSL connections. Stop requiring typing-extensions. Enable tracemalloc for tests, and add the possibility to run the tests with profiling enabled. Fix some issues identified by tracemalloc, like sockets not being closed in case of SSL handshake failures. Remove the CI test reporting plugin, it does not work easily with forked repos anyway. Fix checking of module versions, make the comparison accurate. Not sure how it worked before, but it looks like it did not match exactly the format in the server INFO response, i.e. MMmmPP. Remove loggers from tests, it's just noise in the output. If we don't use asserts, nobody will check the log output from CI. Speed up the computation for slots when initializing a cluster. After profiling, this turned out to be very slow, when it does not have to be. It does not make sense to recompute the same thing over and over in a loop. Run uvloop tests in matrix, i.e. don't bundle two tests executions (without uvloop and with it) in the same job. Easier to spot failures like this, and arguably the jobs can be scheduled in parallel so the overall execution is faster. Unlock urllib version, to be able to use more recent pytest versions. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Add support for Python 3.12. This required a bunch of changes all over the place, listed below in a random order. Fix tests, especially around SSL connections. Stop requiring typing-extensions. Enable tracemalloc for tests, and add the possibility to run the tests with profiling enabled. Fix some issues identified by tracemalloc, like sockets not being closed in case of SSL handshake failures. Remove the CI test reporting plugin, it does not work easily with forked repos anyway. Fix checking of module versions, make the comparison accurate. Not sure how it worked before, but it looks like it did not match exactly the format in the server INFO response, i.e. MMmmPP. Remove loggers from tests, it's just noise in the output. If we don't use asserts, nobody will check the log output from CI. Speed up the computation for slots when initializing a cluster. After profiling, this turned out to be very slow, when it does not have to be. It does not make sense to recompute the same thing over and over in a loop. Run uvloop tests in matrix, i.e. don't bundle two tests executions (without uvloop and with it) in the same job. Easier to spot failures like this, and arguably the jobs can be scheduled in parallel so the overall execution is faster. Unlock urllib version, to be able to use more recent pytest versions. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Add support for Python 3.12. This required a bunch of changes all over the place, listed below in a random order. Fix tests, especially around SSL connections. Stop requiring typing-extensions. Enable tracemalloc for tests, and add the possibility to run the tests with profiling enabled. Fix some issues identified by tracemalloc, like sockets not being closed in case of SSL handshake failures. Remove the CI test reporting plugin, it does not work easily with forked repos anyway. Fix checking of module versions, make the comparison accurate. Not sure how it worked before, but it looks like it did not match exactly the format in the server INFO response, i.e. MMmmPP. Remove loggers from tests, it's just noise in the output. If we don't use asserts, nobody will check the log output from CI. Speed up the computation for slots when initializing a cluster. After profiling, this turned out to be very slow, when it does not have to be. It does not make sense to recompute the same thing over and over in a loop. Run uvloop tests in matrix, i.e. don't bundle two tests executions (without uvloop and with it) in the same job. Easier to spot failures like this, and arguably the jobs can be scheduled in parallel so the overall execution is faster. Unlock urllib version, to be able to use more recent pytest versions. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the trove, and CI to support the Python 3.12 release announcement.
closes #3020